34 lines
1.8 KiB
Markdown
34 lines
1.8 KiB
Markdown
# Raise valuable PR / 提出有价值的PR
|
||
|
||
## Caution/ 注意事项:
|
||
Users should keep the following points in mind when submitting PRs:
|
||
|
||
1. The proposed PR should be about this project.
|
||
2. the proposed PR should be relevant, if there are multiple ideas and optimizations, they should be assigned to different PRs.
|
||
|
||
用户在提交PR时候应该注意以下几点:
|
||
|
||
1. 提出的PR应该是关于本项目的。
|
||
2. 提出的PR应该具有针对性,如果具有多个不同的想法和优化方案,应该分配到不同的PR中。
|
||
|
||
## 不应该提出的PR / PRs that should not be proposed
|
||
|
||
If a developer proposes a PR about any of the following, it may be closed or Rejected.
|
||
|
||
1. those that don't describe improvement options.
|
||
2. multiple issues of different types combined in one PR.
|
||
3. The proposed PR is highly duplicative of already existing PRs.
|
||
|
||
如果开发者提出关于以下方面的PR,则可能会被直接关闭或拒绝通过。
|
||
|
||
1. 没有说明改进方案的。
|
||
2. 多个不同类型的问题合并在一个PR中的。
|
||
3. 提出的PR与已经存在的PR高度重复的。
|
||
|
||
|
||
# 检查您的PR
|
||
- [ ] Have you read the Contributor Guidelines, Pull Request section? / 您是否阅读了贡献者指南、Pull Request 部分?
|
||
- [ ] Has this been discussed/approved via a Github issue or forum? If so, add a link. / 是否通过 Github 问题或论坛讨论/批准过?如果是,请添加链接。
|
||
- [ ] Did you make sure you updated the documentation with your changes? Here are the Documentation Guidelines, and here are the Documentation Formatting Tips. /您是否确保根据您的更改更新了文档?这里是文档指南,这里是文档格式化技巧。
|
||
- [ ] Did you write new required tests? / 您是否编写了新的必要测试?
|
||
- [ ] Are your PRs for only one issue / 您的PR是否仅针对一个问题 |